Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-43703: [C++][Parquet][CI] Parquet: Introducing more bad_data for testing #43708

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

mapleFU
Copy link
Member

@mapleFU mapleFU commented Aug 15, 2024

Rationale for this change

Introducing more bad_data for testing

What changes are included in this PR?

  • Upgrade parquet-testing
  • Introduce more bad_data
  • Update fuzz generation

Are these changes tested?

They're tests :-)

Are there any user-facing changes?

no

@mapleFU mapleFU requested a review from wgtmac as a code owner August 15, 2024 10:32
@mapleFU mapleFU requested review from pitrou and removed request for wgtmac August 15, 2024 10:32
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@pitrou
Copy link
Member

pitrou commented Aug 15, 2024

@mapleFU mapleFU changed the title [C++][Parquet][CI] Parquet: Introducing more bad_data for testing GH-43703: [C++][Parquet][CI] Parquet: Introducing more bad_data for testing Aug 15, 2024
Copy link

⚠️ GitHub issue #43703 has been automatically assigned in GitHub to PR creator.

@mapleFU
Copy link
Member Author

mapleFU commented Aug 15, 2024

Fixed now

@pitrou
Copy link
Member

pitrou commented Aug 15, 2024

@github-actions crossbow submit -g cpp

Copy link

Revision: 128df48

Submitted crossbow builds: ursacomputing/crossbow @ actions-5197d794dc

Task Status
test-alpine-linux-cpp GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-cuda-cpp GitHub Actions
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-fedora-39-cpp GitHub Actions
test-ubuntu-20.04-cpp GitHub Actions
test-ubuntu-20.04-cpp-bundled GitHub Actions
test-ubuntu-20.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-20.04-cpp-thread-sanitizer GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundled GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thank you @mapleFU

@pitrou pitrou merged commit fb202ee into apache:main Aug 15, 2024
34 of 35 checks passed
@pitrou pitrou removed the awaiting review Awaiting review label Aug 15, 2024
@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Aug 15, 2024
@mapleFU mapleFU deleted the introduce-bad-data branch August 15, 2024 13:09
Copy link

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit fb202ee.

There were 2 benchmark results indicating a performance regression:

The full Conbench report has more details. It also includes information about 11 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants