GH-40153: [C++][Python] Fix test_gdb failures on 32-bit #40293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@github-actions crossbow submit -g python |
github-actions
bot
added
Component: C++
Component: Python
awaiting review
This comment was marked as outdated.
This comment was marked as outdated.
|
@AlenkaF @jorisvandenbossche Does one of you want to comment on this? |
|
No comment on the code, looks good to me. |
Yes, it is. |
pitrou
force-pushed
the
gh40153-test-gdb-i386
branch
from
11012a9 to
d42ed96
Compare
|
@github-actions crossbow submit -g python |
|
Revision: d42ed96 Submitted crossbow builds: ursacomputing/crossbow @ actions-c765d70b22
|
AlenkaF
approved these changes
Mar 5, 2024
github-actions
bot
added
awaiting committer review
|
Test failures are unrelated. |
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 53e0c74. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
mapleFU
pushed a commit
to mapleFU/arrow
that referenced
this pull request
Mar 7, 2024
…#40293) ### Rationale for this change `test_gdb.py` would fail on 32-bit platforms because the gdb extension errors out when a timestamp value is larger than the platform's time_t. ### What changes are included in this PR? 1. Catch `OverflowError` from the Python datetime module when trying to format a timestamp 2. Tweak the expected test results on 32-bit ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#40153 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Mar 8, 2024
…#40293) ### Rationale for this change `test_gdb.py` would fail on 32-bit platforms because the gdb extension errors out when a timestamp value is larger than the platform's time_t. ### What changes are included in this PR? 1. Catch `OverflowError` from the Python datetime module when trying to format a timestamp 2. Tweak the expected test results on 32-bit ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#40153 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
test_gdb.pywould fail on 32-bit platforms because the gdb extension errors out when a timestamp value is larger than the platform's time_t.What changes are included in this PR?
OverflowErrorfrom the Python datetime module when trying to format a timestampAre these changes tested?
Yes.
Are there any user-facing changes?
No.