WIP: [Release] Verify release-15.0.1-rc0 #40211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, mamba might select PyPy over CPython in certain environment upgrade/downgrade scenarios. * Closes: #40112 Lead-authored-by: Antoine Pitrou <[email protected]> Co-authored-by: Uwe L. Korn <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
…39969) ### Rationale for this change The integration tests and documentation build is failing ### What changes are included in this PR? Instead of relying on how reticulate converts an R external pointer, use a Python integer instead. We can't use an R integer (because they're only 32 bits); we can't use an R double (because the static cast to/from uintptr_t is a bit iffy); however, we can use Python to convert a string to Python integer. This is probably how I should have written it the first time but it didn't occur to me at the time. ### Are these changes tested? Yes, covered by existing tests. ### Are there any user-facing changes? No * Closes: #39933 Lead-authored-by: Dewey Dunnington <[email protected]> Co-authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Dewey Dunnington <[email protected]>
### Rationale for this change While #39969 fixed the immediate issue caused by the update of the capsule name used by reticulate whilst converting an R "external pointer", it will still result in an error if somebody is using an older version of the Arrow R package. ### What changes are included in this PR? The pyarrow Cython code was modified to accept capsules with the name NULL or "r_extptr". ### Are these changes tested? Not sure where the best place for this is, but: CRAN arrow + released pyarrow + new reticulate (errors): ``` r library(arrow, warn.conflicts = FALSE) reticulate::use_virtualenv("~/Desktop/rscratch/arrow/.venv") packageVersion("arrow") #> [1] '14.0.0.2' packageVersion("reticulate") #> [1] '1.35.0' pa <- reticulate::import("pyarrow") pa[["__version__"]] #> [1] "15.0.0" reticulate::r_to_py(arrow::int32()) #> PyCapsule_GetPointer called with incorrect name ``` CRAN arrow + pyarrow from this PR + old reticulate: ``` r library(arrow, warn.conflicts = FALSE) reticulate::use_virtualenv("~/Desktop/rscratch/arrow/.venv") packageVersion("arrow") #> [1] '14.0.0.2' packageVersion("reticulate") #> [1] '1.34.0' pa <- reticulate::import("pyarrow") pa[["__version__"]] #> [1] "16.0.0.dev92+geafcff7a5" reticulate::r_to_py(arrow::int32()) #> DataType(int32) ``` CRAN arrow + pyarrow from this PR + new reticulate: ``` r library(arrow, warn.conflicts = FALSE) reticulate::use_virtualenv("~/Desktop/rscratch/arrow/.venv") packageVersion("arrow") #> [1] '14.0.0.2' packageVersion("reticulate") #> [1] '1.35.0' pa <- reticulate::import("pyarrow") pa[["__version__"]] #> [1] "16.0.0.dev92+geafcff7a5" reticulate::r_to_py(arrow::int32()) #> DataType(int32) ``` ### Are there any user-facing changes? No * Closes: #39942 Lead-authored-by: Dewey Dunnington <[email protected]> Co-authored-by: Dewey Dunnington <[email protected]> Co-authored-by: Antoine Pitrou <[email protected]> Co-authored-by: Joris Van den Bossche <[email protected]> Signed-off-by: Dewey Dunnington <[email protected]>
…ng (#40175) ### Rationale for this change Remove `ThrowsMessage` for CI build. ### What changes are included in this PR? Remove `ThrowsMessage` for CI build. ### Are these changes tested? no need ### Are there any user-facing changes? no * Closes: #40174 Authored-by: mwish <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
|
@github-actions crossbow submit --group verify-rc-source --param release=15.0.1 --param rc=0 |
raulcd
requested review from
assignUser,
kou,
paleolimbot,
thisisnic,
kevingurney,
domoritz,
trxcllnt,
lidavidm,
zeroshade,
westonpace and
wgtmac
as code owners
github-actions
bot
added
Component: MATLAB
Component: Documentation
awaiting committer review
|
Revision: 5ce6ff4 Submitted crossbow builds: ursacomputing/crossbow @ release-15.0.1-rc0-0
|
|
Revision: 5ce6ff4 Submitted crossbow builds: ursacomputing/crossbow @ actions-48134e40c7
|
|
@github-actions crossbow submit --group verify-rc-binaries --group verify-rc-wheels --param release=15.0.1 --param rc=0 |
|
Revision: 5ce6ff4 Submitted crossbow builds: ursacomputing/crossbow @ actions-49b96c130f
|
|
Ah, sorry. I should have used I'm re-running |
|
Done. Re-run verify-rc-binaries-apt-linux-amd64. |
|
ok, the wheels failed because of the leap year bug (not great to run verification on 29th February 😂) |
|
There seems to be a different error for Windows builds on @jorisvandenbossche @AlenkaF have you seen this error before? |
I haven't seen it before and also can't reproduce it on MacOS. As mentioned on Zulip channel, there was a new release of the dateutil package. The version of
I do not see how the changes in the new dateutil version would affect the Windows builds though ... |
|
@ursabot please benchmark |
|
Benchmark runs are scheduled for commit 5ce6ff4. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete. |
|
Thanks for your patience. Conbench analyzed the 0 benchmarking runs that have been run so far on PR commit 5ce6ff4. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
|
The benchmarks failed because they couldn't build the pyarrow wheel due to #40386. |
|
Thanks @austin3dickey ! I am creating the 15.0.2 release which only contains 4 fixes at the moment, 3 of them are CI/build issues that won't affect performance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to verify Release Candidate