-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++] Segmentation fault in hash-join/swiss-join #39951
Comments
Thanks for reporting. For me, it's hard to see the cause from this bare stack. It'll help to have a cpp test case, not necessarily small though, to reproduce the crash, even randomly. Alternatively, if you are able to build your own arrow, it would also help to enable ASAN by adding cmake options |
Enabling ASAN makes this crash go away. Lowering |
Thanks for the experiments. Though I can only guess what was happening, I think we are making progress. First I think the errors reported by TSAN don't seem to be related to this crash. But the fired assertion does. It indicates that an arrow-managed stack-like temp buffer is overflowed and possibly causing subsequent unexpected behaviors. It also explains why lowering To verify if the fired assertion is the root cause, could you try something similar to #40007 and see if it resolves the issue? |
I agree that TSAN crashes seem unrelated, I've reported them for completeness only. Then again, you never know with races. The patch in #40007 seems to resolve my case, thank you! Looks like that PR will be merged and a new "investigate why this is even needed" issue will be open. If it's the case I suggest linking this issue there, and for now I'm closing it. |
Describe the bug, including details regarding any error messages, version, and platform.
Continuing from #32570
Here is the crash I see in my code occasionally. Unfortunately, I do not have a small or even a reliable test case to reproduce.
@zanmato1984 fixed several crashes related to hash join before, I suspect this one may be another case from that family.
Component(s)
C++
The text was updated successfully, but these errors were encountered: