Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JS] make @swc/helpers dev dependency or make ts-node a dependency #39476

Closed
domoritz opened this issue Jan 5, 2024 · 2 comments
Closed

[JS] make @swc/helpers dev dependency or make ts-node a dependency #39476

domoritz opened this issue Jan 5, 2024 · 2 comments
Labels
Component: JavaScript Type: enhancement

Comments

@domoritz
Copy link
Member

domoritz commented Jan 5, 2024

Describe the enhancement requested

@swc/helpers is only used with ts-node so it should be the same I think.

This was introduced in #38500.

Component(s)

JavaScript
@domoritz
Copy link
Member Author

domoritz commented Jan 5, 2024

@trxcllnt thoughts?

@trxcllnt
Copy link
Contributor

trxcllnt commented Jan 5, 2024 •
edited
Loading

The ts-node docs about swc says we need it if we're using "importHelpers": true in our tsconfig:

SWC uses @swc/helpers instead of tslib. If you have enabled importHelpers, you must also install @swc/helpers.

@domoritz domoritz closed this as not planned Won't fix, can't repro, duplicate, stale Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: JavaScript Type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trxcllnt @domoritz