Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go][Integration] Add support for Utf8View to the go implementation #38718

Closed
bkietz opened this issue Nov 14, 2023 · 0 comments · Fixed by #35769
Closed

[Go][Integration] Add support for Utf8View to the go implementation #38718

bkietz opened this issue Nov 14, 2023 · 0 comments · Fixed by #35769
Assignees
@zeroshade
Labels
Component: Go Component: Integration Type: enhancement
Milestone
15.0.0

Comments

@bkietz
Copy link
Member

bkietz commented Nov 14, 2023

Describe the enhancement requested

Utf8View was added to the format in
#35627 and c++ support added in #37792

Component(s)

Go, Integration
@bkietz bkietz mentioned this issue Nov 14, 2023
Merged
bkietz pushed a commit that referenced this issue Nov 14, 2023
@zeroshade @candiduslynx
GH-38718: [Go][Format][Integration] Add StringView/BinaryView to Go i…
26149d9 
…mplementation (#35769)

### Rationale for this change
See #35628 for the rationale and description of the StringView/BinaryView array types.

This change is adding Go as a second implementation of it.

### What changes are included in this PR?

Add Array Types for `StringView` and `BinaryView` along with `StringViewType` and `BinaryViewType` and necessary enums and builders. These arrays can be round tripped through JSON and IPC.

### Are these changes tested?
Yes, unit tests have been added and integration tests run

* Closes: [#38718](#38718)
* Closes: #38718

Lead-authored-by: Matt Topol <[email protected]>
Co-authored-by: Alex Shcherbakov <[email protected]>
Signed-off-by: Benjamin Kietzman <[email protected]>
@bkietz bkietz added this to the 15.0.0 milestone Nov 14, 2023
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@zeroshade @candiduslynx @dgreiss
apacheGH-38718: [Go][Format][Integration] Add StringView/BinaryView t…
a3a83ce 
…o Go implementation (apache#35769)

### Rationale for this change
See apache#35628 for the rationale and description of the StringView/BinaryView array types.

This change is adding Go as a second implementation of it.

### What changes are included in this PR?

Add Array Types for `StringView` and `BinaryView` along with `StringViewType` and `BinaryViewType` and necessary enums and builders. These arrays can be round tripped through JSON and IPC.

### Are these changes tested?
Yes, unit tests have been added and integration tests run

* Closes: [apache#38718](apache#38718)
* Closes: apache#38718

Lead-authored-by: Matt Topol <[email protected]>
Co-authored-by: Alex Shcherbakov <[email protected]>
Signed-off-by: Benjamin Kietzman <[email protected]>
kou pushed a commit to apache/arrow-go that referenced this issue Aug 30, 2024
@zeroshade @candiduslynx @kou
GH-38718: [Go][Format][Integration] Add StringView/BinaryView to Go i…
217141a 
…mplementation (#35769)

### Rationale for this change
See #35628 for the rationale and description of the StringView/BinaryView array types.

This change is adding Go as a second implementation of it.

### What changes are included in this PR?

Add Array Types for `StringView` and `BinaryView` along with `StringViewType` and `BinaryViewType` and necessary enums and builders. These arrays can be round tripped through JSON and IPC.

### Are these changes tested?
Yes, unit tests have been added and integration tests run

* Closes: [#38718](apache/arrow#38718)
* Closes: #38718

Lead-authored-by: Matt Topol <[email protected]>
Co-authored-by: Alex Shcherbakov <[email protected]>
Signed-off-by: Benjamin Kietzman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeroshade zeroshade

Labels
Component: Go Component: Integration Type: enhancement
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-38718: [Go][Format][Integration] Add StringView/BinaryView to Go implementation zeroshade/arrow
2 participants
@zeroshade @bkietz