Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java][FlightRPC] FlightServer builder should store File, not InputStream #38586

Open
lidavidm opened this issue Nov 4, 2023 · 0 comments
Open

[Java][FlightRPC] FlightServer builder should store File, not InputStream #38586

lidavidm opened this issue Nov 4, 2023 · 0 comments
Labels
Component: FlightRPC Component: Java Type: bug

Comments

@lidavidm
Copy link
Member

lidavidm commented Nov 4, 2023 •
edited
Loading

Describe the bug, including details regarding any error messages, version, and platform.

Methods like useTls and useMTlsClientVerification should store a File instead of opening the file immediately, then at build time we can open the file and make sure to close the input stream (as required by Netty). This minimizes the logic in the builder setters. Followup for #38461

Component(s)

FlightRPC, Java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: FlightRPC Component: Java Type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lidavidm