Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-37889: [Java][Doc] Improve JDBC driver documentation #38469

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

jduo
Copy link
Member

@jduo jduo commented Oct 25, 2023

Rationale for this change

Correct inaccuracies and better document how to connect with the Flight SQL JDBC Driver.

What changes are included in this PR?

  • Correct the user property.
  • Correct the default for useEncryption.
  • Elaborate on using the Properties object when connecting and describe the order of precedence.

Are these changes tested?

N/A

Are there any user-facing changes?

Yes

@github-actions
Copy link

⚠️ GitHub issue #1115 has been automatically assigned in GitHub to PR creator.

@github-actions
Copy link

⚠️ GitHub issue #37899 has no components, please add labels for components.

- Correct the user property.
- Correct the default for useEncryption.
- Elaborate on using the Properties object when connecting
and describe the order of precedence.
- Mention URI-encoding of option values.
@jduo jduo changed the title GH-37899: [Java][Doc] Improve JDBC driver documentation GH-37889: [Java][Doc] Improve JDBC driver documentation Oct 26, 2023
@jduo
Copy link
Member Author

jduo commented Oct 27, 2023

@lidavidm @danepitkin

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Oct 27, 2023
- false
- Whether to use TLS (the default is an insecure, plaintext
connection)
- true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe discuss if this is case sensitive? When I was setting up DBeaver, all the other major parameters were in the form FOO_BAR, and this one is documented as fooBar

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, all parameters should be camelCase per:

public enum ArrowFlightConnectionProperty implements ConnectionProperty {

and

Though the get() implementation seems to also allow fully lower-case. It's probably supposed to be case-insensitive though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's explicitly document whether it's case-sensitive or not, and maybe we can split out a separate ticket to make it case-insensitive if needed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've documented that names are case-sensitive for simplicity's sake.

If we want to be more precise, names are case-insensitive on the connection URI (since we internally lower-case them after parsing) and case-sensitive in the Properties object, but really they should consistently be case-insensitive.

@adamkennedy
Copy link

Other than the one comment above, these fixes are helpful

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels Oct 27, 2023
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Oct 27, 2023
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Oct 27, 2023
@lidavidm lidavidm merged commit b42d44e into apache:main Oct 30, 2023
8 checks passed
@lidavidm lidavidm removed the awaiting merge Awaiting merge label Oct 30, 2023
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit b42d44e.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
…#38469)

### Rationale for this change
Correct inaccuracies and better document how to connect with the Flight SQL JDBC Driver.

### What changes are included in this PR?
- Correct the user property.
- Correct the default for useEncryption.
- Elaborate on using the Properties object when connecting and describe the order of precedence.

### Are these changes tested?
N/A

### Are there any user-facing changes?
Yes
* Closes: apache#37889 

Authored-by: James Duong <[email protected]>
Signed-off-by: David Li <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…#38469)

### Rationale for this change
Correct inaccuracies and better document how to connect with the Flight SQL JDBC Driver.

### What changes are included in this PR?
- Correct the user property.
- Correct the default for useEncryption.
- Elaborate on using the Properties object when connecting and describe the order of precedence.

### Are these changes tested?
N/A

### Are there any user-facing changes?
Yes
* Closes: apache#37889 

Authored-by: James Duong <[email protected]>
Signed-off-by: David Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Java][Docs] JDBC Arrow Flight SQL Driver documentation
3 participants