Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-38297: [C#] Fix build for .NET 4.7.2 #38299

Merged
merged 1 commit into from
Oct 16, 2023
Merged

GH-38297: [C#] Fix build for .NET 4.7.2 #38299

merged 1 commit into from
Oct 16, 2023

Conversation

CurtHagenlocher
Copy link
Contributor

@CurtHagenlocher CurtHagenlocher commented Oct 16, 2023 •
edited by github-actions bot
Loading

What changes are included in this PR?

Fixes #38297

Are these changes tested?

Yes

@CurtHagenlocher
Copy link
Contributor Author

As these are trivial changes aimed at fixing the build, I'm going to check in the changes without additional review and ask for forgiveness if required... .

@CurtHagenlocher CurtHagenlocher merged commit 71a76c3 into apache:main Oct 16, 2023
8 checks passed
@CurtHagenlocher CurtHagenlocher deleted the Net472Fix branch October 16, 2023 23:02
@kou
Copy link
Member

kou commented Oct 16, 2023

@CurtHagenlocher Could you use our merge script instead of the GitHub's merge button?
https://github.com/apache/arrow/tree/main/dev#how-to-merge-a-pull-request

@CurtHagenlocher
Copy link
Contributor Author

Oops, sorry :(. Guess I didn't read nearly enough.

@kou
Copy link
Member

kou commented Oct 16, 2023

We may need to create a document for new committer in https://arrow.apache.org/docs/ instead of using dev/README.md...

@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 71a76c3.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

JerAguilon pushed a commit to JerAguilon/arrow that referenced this pull request Oct 23, 2023
@CurtHagenlocher
apacheGH-38297: [C#] Fix build for .NET 4.7.2 (apache#38299)
f983017 
### What changes are included in this PR?

Fixes apache#38297 

### Are these changes tested?

Yes
* Closes: apache#38297
loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
@CurtHagenlocher @loicalleyne
apacheGH-38297: [C#] Fix build for .NET 4.7.2 (apache#38299)
55e6f5e 
### What changes are included in this PR?

Fixes apache#38297 

### Are these changes tested?

Yes
* Closes: apache#38297
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
@CurtHagenlocher @dgreiss
apacheGH-38297: [C#] Fix build for .NET 4.7.2 (apache#38299)
b500655 
### What changes are included in this PR?

Fixes apache#38297 

### Are these changes tested?

Yes
* Closes: apache#38297
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonpace westonpace Awaiting requested review from westonpace

Assignees
No one assigned
Labels
awaiting review Awaiting review Component: C#
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[C#] Duration checkin broke build for .NET 4.7.2
2 participants
@CurtHagenlocher @kou