Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Use shared_ptr<DataType> less throughout arrow/compute #32541

Open
asfimport opened this issue Jul 29, 2022 · 0 comments
Open

[C++] Use shared_ptr<DataType> less throughout arrow/compute #32541

asfimport opened this issue Jul 29, 2022 · 0 comments

Comments

@asfimport
Copy link
Collaborator

It turns out we generate a ton of code just copying and manipulating shared_ptr<DataType> throughput arrow/compute, and especially in the configuration of the function/kernels registry. One function RegisterScalarArithmetic generates around 300kb of code, which on looking at disassembly contains a significant amount of inlined shared_ptr template code. I made an attempt to refactoring things to use const DataType* for function signatures which removes quite a bit of code bloat, and puts us on a path to using fewer shared_ptr's in general

Reporter: Wes McKinney / @wesm
Assignee: Wes McKinney / @wesm

PRs and other links:

Note: This issue was originally created as ARROW-17259. Please see the migration documentation for further details.

@asfimport asfimport added this to the 11.0.0 milestone Jan 11, 2023
@raulcd raulcd removed this from the 11.0.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants