Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Use tzdata timezone database on Windows #31472

Open
asfimport opened this issue Mar 28, 2022 · 8 comments
Open

[Python] Use tzdata timezone database on Windows #31472

asfimport opened this issue Mar 28, 2022 · 8 comments

Comments

@asfimport
Copy link
Collaborator

asfimport commented Mar 28, 2022

In ARROW-13168, we enabled setting the path of the text-based database engine at runtime. This allowed R to use the tzdb package for the timezone database, since it uses the text format.

However, it doesn't seem like tzdata Python package ships that text format. They do have a "compact" text format, which might be compatible with our vendored date library. Otherwise, we'd likely have to wait for binary format support in HowardHinnant/date#564

Reporter: Will Jones / @wjones127
Watchers: Rok Mihevc / @rok

Related issues:

Note: This issue was originally created as ARROW-16054. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Antoine Pitrou / @pitrou:
I doubt the compact text format is compatible with the date library, it's just an input format for generating the binary files (IIUC). But worth trying probably.

@asfimport
Copy link
Collaborator Author

Michael Sterling:
It's very possible I'm missing something but would it be possible to enable the setting a timezone-path for Python as well even if users have to figure out how to get the timezone database in the correct format?

@asfimport
Copy link
Collaborator Author

@asfimport
Copy link
Collaborator Author

Rok Mihevc / @rok:
See https://stackoverflow.com/a/74292266/10615379 for a workaround.

@AlenkaF
Copy link
Member

AlenkaF commented Aug 15, 2023

PR to skip the failing tests on Windows that require a tz database: #36996 (interim solution)

@h-vetinari
Copy link
Contributor

Are things still being backported to the branch for 13.0? If so, I think #36996 would make sense, as it will cause test failures on windows otherwise.

CC @raulcd

@raulcd
Copy link
Member

raulcd commented Aug 16, 2023

Are things still being backported to the branch for 13.0? If so, I think #36996 would make sense, as it will cause test failures on windows otherwise.

CC @raulcd

From my understanding the original error was introduced on #36323 which is not part of 13.0.0

@h-vetinari
Copy link
Contributor

From my understanding the original error was introduced on #36323 which is not part of 13.0.0

Ah OK great! Thanks for the info.

Background: I remember seeing a tzdata failure when I had built from source a while ago, but I had already tested one of the rc's, and it passed as well on windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants