Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][Compute] Hash Join support for dictionary #29767

Closed
asfimport opened this issue Sep 30, 2021 · 6 comments
Closed

[C++][Compute] Hash Join support for dictionary #29767

asfimport opened this issue Sep 30, 2021 · 6 comments

Comments

@asfimport
Copy link
Collaborator

asfimport commented Sep 30, 2021

Currently dictionary arrays are not supported at all as input columns to hash join.

Add support for dictionary arrays in hash join for both key columns and payload columns.

Reporter: Michal Nowakiewicz / @michalursa
Assignee: Michal Nowakiewicz / @michalursa

Related issues:

PRs and other links:

Note: This issue was originally created as ARROW-14181. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Neal Richardson / @nealrichardson:
Issue resolved by pull request 11446
#11446

@asfimport
Copy link
Collaborator Author

Kouhei Sutou / @kou:
This has conflicts on maint-6.0.x branch.
Is this really needed for 6.0.1? It seems that this is not a bug fix.

@asfimport
Copy link
Collaborator Author

Kouhei Sutou / @kou:
This requires ARROW-14310 and ARROW-14310 requires something. Is this intended?

@asfimport
Copy link
Collaborator Author

Kouhei Sutou / @kou:
ARROW-14310 requires ARROW-13156.

@asfimport
Copy link
Collaborator Author

@asfimport
Copy link
Collaborator Author

Neal Richardson / @nealrichardson:
I would like this in the patch release, it will appear as a bug to users. The conflict sounds like it is only in the R tests I updated in r/tests/testthat/test-dplyr-join.R (from 8e688d6), so feel free to drop that R test change, it is not strictly necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant