Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][Compute] Join: add set membership test method to the grouper #29186

Closed
asfimport opened this issue Aug 3, 2021 · 1 comment
Closed

Comments

@asfimport
Copy link
Collaborator

asfimport commented Aug 3, 2021

Hash table used in group by provides one main method: map. 
This method will find an existing matching key in the hash table and output the corresponding group id, it the key already has been inserted in the hash table. Otherwise it will insert a new key and assign a new group id value to it.

This interface is tailored for the group by. In order to reuse the same hash table implementation in join, there must be a way to skip insertion of new keys into the hash table when looking up existing keys. When join processes probe side it needs to filter input rows based on finding a match in the hash table, but keeping hash table immutable and not automatically adding missing keys to it.

Reporter: Michal Nowakiewicz / @michalursa
Assignee: Michal Nowakiewicz / @michalursa

Related issues:

PRs and other links:

Note: This issue was originally created as ARROW-13532. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Ben Kietzman / @bkietz:
Issue resolved by pull request 10858
#10858

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant