Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Log functions don't have int kernels #28967

Closed
asfimport opened this issue Jul 8, 2021 · 3 comments
Closed

[C++] Log functions don't have int kernels #28967

asfimport opened this issue Jul 8, 2021 · 3 comments

Comments

@asfimport
Copy link
Collaborator

I've been writing R bindings for the log functions implemented in this PR: #10567

They work when the inputs are floats, but when the input is an int32 I get the following error:

NotImplemented: Function ln_checked has no kernel matching input types (scalar[int32])

 

Reporter: Nicola Crane / @thisisnic
Assignee: David Li / @lidavidm

PRs and other links:

Note: This issue was originally created as ARROW-13289. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

David Li / @lidavidm:
Ah, sorry, during the review for either trig or log functions it was questioned whether having integer variants was useful, so I removed them. Maybe I can have it auto-promote integer arguments to floating point ones?

@asfimport
Copy link
Collaborator Author

Nicola Crane / @thisisnic:
Sounds like a great solution to me! :)

@asfimport
Copy link
Collaborator Author

David Li / @lidavidm:
Issue resolved by pull request 10686
#10686

@asfimport asfimport added this to the 5.0.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants