[C++] Fix errors from VS 2019 in cpp/src/parquet/types.h

[asfimport]

On April 30, a nightly CI job that builds libarrow with Visual Studio 2019 (test-build-vcpkg-win) started failing because of numerous syntax errors:

D:\a\crossbow\crossbow\arrow\cpp\src\parquet/types.h(115,38): error C2143: syntax error: missing '}' before '=' [D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\dataset\arrow_dataset_shared.vcxproj]
4423D:\a\crossbow\crossbow\arrow\cpp\src\parquet/types.h(115,38): error C2059: syntax error: '=' [D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\dataset\arrow_dataset_shared.vcxproj]
4424D:\a\crossbow\crossbow\arrow\cpp\src\parquet/types.h(115,87): error C2143: syntax error: missing ';' before '}' [D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\dataset\arrow_dataset_shared.vcxproj]
4425D:\a\crossbow\crossbow\arrow\cpp\src\parquet/types.h(115,87): error C2238: unexpected token(s) preceding ';' [D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\dataset\arrow_dataset_shared.vcxproj]
4426D:\a\crossbow\crossbow\arrow\cpp\src\parquet/types.h(173,22): error C2039: 'schema': is not a member of 'parquet' [D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\dataset\arrow_dataset_shared.vcxproj]
4427D:\a\crossbow\crossbow\arrow\cpp\src\parquet/types.h(40): message : see declaration of 'parquet' [D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\dataset\arrow_dataset_shared.vcxproj]
4428D:\a\crossbow\crossbow\arrow\cpp\src\parquet/types.h(173,22): error C3083: 'schema': the symbol to the left of a '::' must be a type [D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\dataset\arrow_dataset_shared.vcxproj]
4429D:\a\crossbow\crossbow\arrow\cpp\src\parquet/types.h(173,30): error C2039: 'DecimalMetadata': is not a member of 'parquet' 

See full log at https://github.com/ursacomputing/crossbow/runs/2473230854#step:4:4422

@bkietz [~davidli]  I am almost certain that this was caused by ARROW-11929

PR: #10166

Commit: 7430bbd

When I check out the commit immediately before this one, the build succeeds without these errors. When I check out this commit, the build shows these errors.

I believe the issue is not directly related to vcpkg. It happens also when I use conda for dependencies. It seems to be related to Visual Studio 2019.

Reporter: Ian Cook / @ianmcook
Assignee: Ian Cook / @ianmcook

PRs and other links:

• GitHub Pull Request #10234

_{Note: This issue was originally created as ARROW-12640. Please see the migration documentation for further details.}

[asfimport]

Antoine Pitrou / @pitrou:
Can you try adding the following lines somewhere in src/parquet/types.h:

#ifdef OPTIONAL
#undef OPTIONAL
#endif

[asfimport]

David Li / @lidavidm:
I can confirm Antoine's suggestion fixes the error in a local build.

[asfimport]

Ian Cook / @ianmcook:
@pitrou  that solved it; thank you.

Does it matter where in the file I add this? Should it be at the top?

[asfimport]

Ian Cook / @ianmcook:
Oh, I see—I'll add this to the top of  src/parquet/types.h just below #pragma once:

#include "parquet/windows_compatibility.h" 

[asfimport]

Antoine Pitrou / @pitrou:
Please don't. This will indirectly include windows.h. We don't want to do this in header files.

[asfimport]

Ian Cook / @ianmcook:
Ah, ok. Then I'll just add this below the includes:

#ifdef _WIN32

// parquet.thrift's OPTIONAL RepetitionType conflicts with a #define from
// above, so we undefine it
#ifdef OPTIONAL
#undef OPTIONAL
#endif

#endif 

[asfimport]

Ian Cook / @ianmcook:
Issue resolved by pull request 10234
#10234