Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][Dataset][Compute] Replace UnionDataset with Union ExecNode #27813

Closed
asfimport opened this issue Mar 16, 2021 · 6 comments
Closed

[C++][Dataset][Compute] Replace UnionDataset with Union ExecNode #27813

asfimport opened this issue Mar 16, 2021 · 6 comments

Comments

@asfimport
Copy link
Collaborator

asfimport commented Mar 16, 2021

UnionDataset allows Fragments of multiple schemas and differing file formats to be scanned together as a single Dataset. This is useful functionality but makes the Dataset interface somewhat difficult to reason about since it must be general enough to accommodate UnionDataset.

After ARROW-11928 it will probably be more natural to support unioning of datasets through a subclass of ExecNode. Reconciliation of differing schemas can then be trivially handled by a full ProjectNode.

Note this would obviate both ARROW-11001 and ARROW-11749. In addition, Dataset could be simplified to a concrete class containing a set of compatibly typed/formatted Fragments.

Reporter: Ben Kietzman / @bkietz
Assignee: Alexander Ocsa / @aocsa

Related issues:

PRs and other links:

Note: This issue was originally created as ARROW-11981. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Ben Kietzman / @bkietz:
[~davidli] @westonpace

@asfimport
Copy link
Collaborator Author

Weston Pace / @westonpace:
It does raise the question of whether dataset scanning itself should be an exec node?

@asfimport
Copy link
Collaborator Author

David Li:
@bkietz Sorry, you've got the wrong  [~davidli]. I am not associated with this project! :D

@asfimport
Copy link
Collaborator Author

Weston Pace / @westonpace:
@lidavidm

@asfimport
Copy link
Collaborator Author

David Li / @lidavidm:
(I usually go by lidavidm since my name is rather common, but I wonder if I shouldn't just change my name sometimes…)

To Weston's question - I think that's the plan, to have datasets as just another note in the pipeline, and to move projection/filtering into the pipeline and out of the datasets code.

@asfimport
Copy link
Collaborator Author

David Li / @lidavidm:
Issue resolved by pull request 10927
#10927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant