Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Implement power / exponentiation compute kernel #26983

Closed
asfimport opened this issue Dec 29, 2020 · 4 comments
Closed

[C++] Implement power / exponentiation compute kernel #26983

asfimport opened this issue Dec 29, 2020 · 4 comments

Comments

@asfimport
Copy link
Collaborator

asfimport commented Dec 29, 2020

We have addition, subtraction, multiplication, and division.

Reporter: Jonathan Keane / @jonkeane
Assignee: Rok Mihevc / @rok

Related issues:

PRs and other links:

Note: This issue was originally created as ARROW-11070. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Jonathan Keane / @jonkeane:
ARROW-11428 may be relevant (though is only implemented in the Rust client there)

@asfimport
Copy link
Collaborator Author

Antoine Pitrou / @pitrou:
The Rust and C++ implementations are entirely distinct, so ARROW-11428 is irrelevant here.

@asfimport
Copy link
Collaborator Author

Joris Van den Bossche / @jorisvandenbossche:
Copying my note about null behaviour from ARROW-11871:

One behavioural aspect that has come up in pandas is the question about what to do with nulls in case of power(null, 0) or power(1, null): propagate the null value (as is otherwise always done for element-wise arithmetic operations), or in this case return an actual result (1 in both cases, in the idea that whathever value the null might represent, the result is always 1). Reference to the pandas issue: pandas-dev/pandas#29997. It seems that eg R (return 1) and SQL (propagate null) have different behaviour on this aspect. So if we want to support both use cases, an option to switch might be needed.

@asfimport
Copy link
Collaborator Author

Neal Richardson / @nealrichardson:
Issue resolved by pull request 9841
#9841

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants