Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust] [DataFusion] Implement COUNT aggregate expression #23008

Closed
Tracked by #21700
asfimport opened this issue Sep 22, 2019 · 4 comments
Closed
Tracked by #21700

[Rust] [DataFusion] Implement COUNT aggregate expression #23008

asfimport opened this issue Sep 22, 2019 · 4 comments

Comments

@asfimport
Copy link
Collaborator

Implement COUNT aggregate expressions. See the SUM implementation for inspiration.

Reporter: Andy Grove / @andygrove

PRs and other links:

Note: This issue was originally created as ARROW-6657. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Davis Silverman:
Hi, I would be interested in completing this. I have it almost implemented, need to do null checking on the value at each row. Is the submit/review process documented anywhere? Thanks!

@asfimport
Copy link
Collaborator Author

Andy Grove / @andygrove:
I'm actually not sure if it is documented or not ... but basically all you need to do is create a PR from your fork and use a title like "ARROW-6657: [Rust] [DataFusion] Implement COUNT in physical query plan" and add the labels "lang-rust" and "datafusion".

You can request reviews too from the Rust committers ... for the DataFusion crate that is mostly me, Paddy Horan and nevi-me right now.

 

 

 

 

 

 

@asfimport
Copy link
Collaborator Author

@asfimport
Copy link
Collaborator Author

Andy Grove / @andygrove:
Issue resolved by pull request 5513
#5513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant