You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Chao Sun / @sunchao:
Yes we can perhaps do that - this is how C++ does anyway.
Originally the problem was: when I compare a buffer I created via Buffer::from(&[1, 2, 3]) versus a buffer created from flatbuffer with the same data, it will fail because on the left hand side the len is less than capacity, but on the right hand side len = capacity.
However thinking on it more, maybe we should not compare buffer directly without other contexts, such as how many valid elements are stored in the buffer. Also, unless we always zero-out the padded bytes in a buffer, comparison on buffer will likely to fail.
Currently
Buffer
only haslen
, but nocapacity
. We should add both.Reporter: Chao Sun / @sunchao
Assignee: Chao Sun / @sunchao
PRs and other links:
Note: This issue was originally created as ARROW-5357. Please see the migration documentation for further details.
The text was updated successfully, but these errors were encountered: