Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Multi argument operator kernel behavior for decimal columns #17762

Closed
asfimport opened this issue Nov 1, 2017 · 3 comments
Closed

[C++] Multi argument operator kernel behavior for decimal columns #17762

asfimport opened this issue Nov 1, 2017 · 3 comments

Comments

@asfimport
Copy link
Collaborator

asfimport commented Nov 1, 2017

This is a JIRA to discuss the behavior of operator kernels that require more than one decimal column input where the column types have a different scale parameter.

For example:

a: decimal(12, 2)
b: decimal(10, 3)

c = a + b

Arithmetic is the primary use case, but anything that needs to efficiently operate on decimal columns with different scales would require this functionality.

I imagine that @jacques-n and folks at Dremio have thought about and solved the problem in Java. If so, we should consider implementing this behavior in C++. Otherwise, I'll do a bit of reading and digging to see how existing systems efficiently handle this problem.

Reporter: Phillip Cloud / @cpcloud

Related issues:

Note: This issue was originally created as ARROW-1761. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Jacques Nadeau / @jacques-n:
Start by taking a look here.
https://github.com/dremio/dremio-oss/blob/master/sabot/kernel/src/main/java/com/dremio/exec/expr/fn/OutputDerivation.java

These are the notes that we have about our scale/precision behaviors (we're actually in the middle of reimplementing decimal using llvm). These are primarily modeled after MS SQL Server's behavior. We can share as we've reimplemented.

@asfimport
Copy link
Collaborator Author

Wes McKinney / @wesm:
This will need to be resolved once adding Decimal support to compute/kernels/scalar_arithmetic.cc

@asfimport
Copy link
Collaborator Author

Antoine Pitrou / @pitrou:
This was done as part of ARROW-12074 (for simple arithmetics).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant