Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ArrayData.align_buffers align child data buffers recursively #6462

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

EnricoMi
Copy link
Contributor

Which issue does this PR close?

Closes #6461.

Rationale for this change

See #6461.

What changes are included in this PR?

Method ArrayData.align_buffers recursively calls align_buffers on all child data.

Are there any user-facing changes?

None except for struct data types being supported from now on. In code documentation is amended.

@github-actions github-actions bot added the arrow Changes to the arrow crate label Sep 26, 2024
@EnricoMi
Copy link
Contributor Author

CC @tustvold

Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@tustvold tustvold merged commit ebcc4a5 into apache:master Sep 27, 2024
26 checks passed
@EnricoMi EnricoMi deleted the align-child-data-buffers branch October 1, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArrayData.align_buffers should support Struct data type / child data
2 participants