-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add len() to InMemoryWriteableCursor #564
Conversation
Thanks @mosyp |
@mosyp it appears clippy has a problem ! https://github.com/apache/arrow-rs/pull/564/checks?check_run_id=3107500562 Can you please fix the error?
|
Codecov Report
@@ Coverage Diff @@
## master #564 +/- ##
==========================================
- Coverage 82.47% 82.44% -0.04%
==========================================
Files 167 167
Lines 46144 46165 +21
==========================================
Hits 38059 38059
- Misses 8085 8106 +21
Continue to review full report at Codecov.
|
Thanks @alamb. I've added the |
Thanks @mosyp ! |
* Add len() to InMemoryWriteableCursor * Add is_empty to make clippy happy
* Add len() to InMemoryWriteableCursor * Add is_empty to make clippy happy Co-authored-by: Mykhailo Osypov <[email protected]>
Which issue does this PR close?
Resolves the delta-io/kafka-delta-ingest#38
Rationale for this change
There's no efficient way to get buffer length unless copying the data via
.data()
func. These changes provide easy and safe way top achieve that.What changes are included in this PR?
Basically the same impl as in
.data()
, but once we've got the ref then thelen()
on the underlying is called instead of copying the bytes.Are there any user-facing changes?
new pub api (?).