Do not check schema for equality in concat_batches #4815
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4800
Closes #4799
Rationale for this change
Per discussion on #4801, this PR stops validating that schemas of the concatenated batches are exactly equal and instead uses the provided schema
While this may hide some subtle bugs in downstream crates, it avoids arrow-rs enforcing an invariant (e.g. that schema equality also includes field metadata) that is not in other downstream crates
Note that mismatched types still generate a useful error message which should catch any egrious errors.
What changes are included in this PR?
Are there any user-facing changes?