Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boolean comparison to scalar kernels for less then, greater than #959

Closed
alamb opened this issue Nov 20, 2021 · 1 comment · Fixed by #977
Closed

Add boolean comparison to scalar kernels for less then, greater than #959

alamb opened this issue Nov 20, 2021 · 1 comment · Fixed by #977
Assignees
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers

Comments

@alamb
Copy link
Contributor

alamb commented Nov 20, 2021

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
We are implementing general purpose implementations of <, <=, >, and >= in DataFusion -- see apache/datafusion#1163

DataFusion uses different implementations if the left or right sides are scalar values vs if the left or right sides are both arrays.

Arrow has the lt_bool, lt_eq_bool, gt_bool, and gt_eq_bool kernels 🎉 added in #860 by @jimexist see docs for lt_bool

However, it does not have corresponding scalar variants, so I implemented simple versions in DataFusion to get the feature but they are not as optimized as they could be.

Describe the solution you'd like
Implement optimized kernels of lt_bool_scalar, lt_eq_bool_scalar gt_bool_scalar, gt_eq_bool_scalar

Simple versions are implemented in apache/datafusion#1163. The optimized versions should follow the pattern demonstrated in @Dandandan 's pr for eq_bool #844 -- namely doing the comparisons in 64-bit chunks when possible.

@alamb alamb added good first issue Good for newcomers arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog labels Nov 20, 2021
@xudong963
Copy link
Member

I want to do it! @alamb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants