impl std::fmt::Write for StringViewBuilder / BinaryViewBuilder #6777
+151
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6373
Rationale for this change
@tlm365 is trying to implement cast from various types to StringView efficiently in
Int
,UInt
, etc) toUtf8View
#6719Also, DataFusion had several places where it would like to write to a StringViewBuilder using standard rust formatting such as
write!
What changes are included in this PR?
Open questions / follow on PRs:
Are there any user-facing changes?
Yes, new APIs + docs