Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArrayData.align_buffers should support Struct data type / child data #6461

Closed
EnricoMi opened this issue Sep 26, 2024 · 1 comment · Fixed by #6462
Closed

ArrayData.align_buffers should support Struct data type / child data #6461

EnricoMi opened this issue Sep 26, 2024 · 1 comment · Fixed by #6462
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@EnricoMi
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Method ArrayData.align_buffers ensures that data in the array buffers are aligned. This is needed if data come from IPC or FFI. In case of DataType::Struct, mis-aligned buffers are currently not aligned by this method, because it only aligns self.buffers, not buffers of self.child_data.

Describe the solution you'd like
Make ArrayData.align_buffers align buffers of child data recursively.

@EnricoMi EnricoMi added the enhancement Any new improvement worthy of a entry in the changelog label Sep 26, 2024
@alamb alamb added the arrow Changes to the arrow crate label Oct 2, 2024
@alamb
Copy link
Contributor

alamb commented Oct 2, 2024

label_issue.py automatically added labels {'arrow'} from #6462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants