Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object_store release tarballs are missing LICENSE and notice files #6233

Closed
alamb opened this issue Aug 13, 2024 · 1 comment · Fixed by #6234
Closed

object_store release tarballs are missing LICENSE and notice files #6233

alamb opened this issue Aug 13, 2024 · 1 comment · Fixed by #6234
Assignees
Labels
bug object-store Object Store Interface

Comments

@alamb
Copy link
Contributor

alamb commented Aug 13, 2024

Describe the bug
As reported by @Xuanwo on the 0.11.0 release thread https://lists.apache.org/thread/wxppr3ronhj9h03thltc1gk1ocqxfx4w

However, I noticed that our tarball is missing the LICENSE and NOTICE files. I believe this is something we need to address.

To Reproduce

Download https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-object-store-rs-0.11.0-rc1 and inspect the contents. They are indeed missing LICENSE and NOTICE.

~/Downloads/apache-arrow-object-store-rs-0.11.0$ ls -al
total 248
drwxr-xr-x@ 12 andrewlamb  staff   384B Aug 12 17:23 ./
drwx------@ 30 andrewlamb  staff   960B Aug 12 17:26 ../
-rw-r--r--@  1 andrewlamb  staff   1.3K Aug 12 17:23 .github_changelog_generator
-rw-r--r--@  1 andrewlamb  staff    93K Aug 12 17:23 CHANGELOG-old.md
-rw-r--r--@  1 andrewlamb  staff   2.3K Aug 12 17:23 CHANGELOG.md
-rw-r--r--@  1 andrewlamb  staff   4.5K Aug 12 17:23 CONTRIBUTING.md
-rw-r--r--@  1 andrewlamb  staff   3.3K Aug 12 17:23 Cargo.toml
-rw-r--r--@  1 andrewlamb  staff   1.9K Aug 12 17:23 README.md
-rw-r--r--@  1 andrewlamb  staff   1.4K Aug 12 17:23 deny.toml
drwxr-xr-x@  3 andrewlamb  staff    96B Aug 12 17:23 dev/
drwxr-xr-x@ 27 andrewlamb  staff   864B Aug 12 17:23 src/
drwxr-xr-x@  3 andrewlamb  staff    96B Aug 12 17:23 tests/
andrewlamb@Andrews-MacBook-Pro-2:~/Downloads/apache-arrow-object-store-rs-0.11.0

Expected behavior
The tarball should include the LICENSE and NOTICE files

Additional context

@alamb
Copy link
Contributor Author

alamb commented Aug 31, 2024

label_issue.py automatically added labels {'object-store'} from #6234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug object-store Object Store Interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant