Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster min/max for string/binary view arrays #6088

Closed
Tracked by #5374
XiangpengHao opened this issue Jul 18, 2024 · 2 comments · Fixed by #6089
Closed
Tracked by #5374

Faster min/max for string/binary view arrays #6088

XiangpengHao opened this issue Jul 18, 2024 · 2 comments · Fixed by #6089
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@XiangpengHao
Copy link
Contributor

XiangpengHao commented Jul 18, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Current min/max support was added in #6053, with a template solution for generic strings. This is suboptimal, as string view can benefit from faster min/max just like it can have faster cmp operations.

Describe the solution you'd like

Use the fast string view cmp operation instead of the generic one. My local testing shows that a special implementation can be twice as fast.

Part of #5374, and apache/datafusion#10918

Describe alternatives you've considered

Additional context

@XiangpengHao XiangpengHao added the enhancement Any new improvement worthy of a entry in the changelog label Jul 18, 2024
@XiangpengHao
Copy link
Contributor Author

take

@alamb
Copy link
Contributor

alamb commented Jul 24, 2024

label_issue.py automatically added labels {'arrow'} from #6089

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
2 participants