Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min/max support for String/BinaryViewArray #6052

Closed
Tracked by #5374
XiangpengHao opened this issue Jul 14, 2024 · 2 comments · Fixed by #6053
Closed
Tracked by #5374

Min/max support for String/BinaryViewArray #6052

XiangpengHao opened this issue Jul 14, 2024 · 2 comments · Fixed by #6053
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@XiangpengHao
Copy link
Contributor

XiangpengHao commented Jul 14, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Part of #5374
We haven't support them yet. In DataFusion query like below, we will need to call min_string_view(), which is not yet implemented

SELECT "SearchPhrase", MIN("URL"), COUNT(*) AS c FROM hits WHERE "URL" LIKE '%google%' AND "SearchPhrase" <> '' GROUP BY "SearchPhrase" ORDER BY c DESC LIMIT 10;

Describe the solution you'd like

Describe alternatives you've considered

Additional context

@XiangpengHao XiangpengHao added the enhancement Any new improvement worthy of a entry in the changelog label Jul 14, 2024
@XiangpengHao
Copy link
Contributor Author

take

@alamb
Copy link
Contributor

alamb commented Jul 24, 2024

label_issue.py automatically added labels {'arrow'} from #6053

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants