-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop tokio
requirement for object_store
crate
#6051
Comments
It would be a fairly major undertaking to decouple the various implementations from I have filed #6055 to track making the dependency on I have also filed #6056 to track decoupling the HTTP client, but I don't really think this is actionable at this stage. Unless we can demonstrate tangible wins for our existing users from switching HTTP client, I think we would need to preserve the ability to use the battle-tested |
Thank you for filing this issue @criccomini I think starting with #6055 is a great first step -- that way the crate could be used without tokio. We could then have a subsequent discussion on how best to provide |
In case anyone cares, here is a related twitter https://twitter.com/andrewlamb1111/status/1812442468853444855 |
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
I'm a library developer. I would like my library to have async code, but not force developers into a specific async runtime (smol, tokio, etc). My library depends on
object_store
, which usesreqwest
, which requirestokio
to run:not currently running on the Tokio runtime.
regardless of async runtime seanmonstar/reqwest#1108My library can't use
object_store
without forcing all my users to adopttokio
as their async runtime.Describe the solution you'd like
I think object_store should drop
reqwest
as a requirement for its cloud integrations. Perhaps adopt a different HTTP client that works with other async reactors as well?Describe alternatives you've considered
We looked at dropping our dependency on
object_store
, but it's such a good library.We are currently using
futures-rs
'sblock_on
, but we get:The text was updated successfully, but these errors were encountered: