Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement benchmarks for compare_op for GenericBinaryView #5903

Closed
Tracked by #5374
alamb opened this issue Jun 17, 2024 · 2 comments · Fixed by #5924
Closed
Tracked by #5374

Implement benchmarks for compare_op for GenericBinaryView #5903

alamb opened this issue Jun 17, 2024 · 2 comments · Fixed by #5924
Labels
arrow Changes to the arrow crate

Comments

@alamb
Copy link
Contributor

alamb commented Jun 17, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Part of #5374

@XiangpengHao added very nice support to compare kernels for GenericBinaryArray in #5900

Describe the solution you'd like
We should add benchmark coverage for these kernels to ensure we don't regress their performance and to help with future optimizations

Describe alternatives you've considered
Add tests for = and != in https://github.com/apache/arrow-rs/blob/master/arrow/benches/comparison_kernels.rs

Additional context

@XiangpengHao
Copy link
Contributor

take

Also relevant to #5922

@alamb alamb added the arrow Changes to the arrow crate label Jul 2, 2024
@alamb
Copy link
Contributor Author

alamb commented Jul 2, 2024

label_issue.py automatically added labels {'arrow'} from #5924

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants