Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New null with view types are not supported #5893

Closed
Tracked by #5374
XiangpengHao opened this issue Jun 15, 2024 · 1 comment · Fixed by #5894
Closed
Tracked by #5374

New null with view types are not supported #5893

XiangpengHao opened this issue Jun 15, 2024 · 1 comment · Fixed by #5894
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@XiangpengHao
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

The following test case should pass, but failed because view types are not handled in ArrayData::new_null (https://github.com/XiangpengHao/arrow-rs/blob/master/arrow-data/src/data.rs#L564)

    #[test]
    fn test_null_view_types() {
        let array_len = 32;
        let array = ArrayData::new_null(&DataType::BinaryView, array_len);
        assert_eq!(array.len(), array_len);
        for i in 0..array.len() {
            assert!(array.is_null(i));
        }
    }

Describe the solution you'd like

Describe alternatives you've considered

Additional context

@alamb
Copy link
Contributor

alamb commented Jul 2, 2024

label_issue.py automatically added labels {'arrow'} from #5894

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants