Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate use of NaiveDateTime in APIs #5480

Open
tustvold opened this issue Mar 6, 2024 · 2 comments
Open

Deprecate use of NaiveDateTime in APIs #5480

tustvold opened this issue Mar 6, 2024 · 2 comments
Labels
enhancement Any new improvement worthy of a entry in the changelog help wanted

Comments

@tustvold
Copy link
Contributor

tustvold commented Mar 6, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

NaiveDateTime is hard to use correctly, and it is very easy to introduce subtle bugs.

https://github.com/chronotope/chrono/releases/tag/v0.4.35 deprecated a large number of methods on NaiveDateTime for this reason, we should follow their example

Describe the solution you'd like

I would like to alter these methods to return DateTime<Utc>

Describe alternatives you've considered

Additional context

@Michael-J-Ward
Copy link
Contributor

@tustvold - Do you want to alter the methods directly or do a deprecate-then-remove cycle?

I started some work on this in #5684 and would like to continue it if you're interested.

@ByteBaker
Copy link
Contributor

@tustvold @alamb I could resume work on this with some direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog help wanted
Projects
None yet
Development

No branches or pull requests

3 participants