Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Interval Subtraction #4489

Closed
tustvold opened this issue Jul 8, 2023 · 1 comment · Fixed by #4493
Closed

Incorrect Interval Subtraction #4489

tustvold opened this issue Jul 8, 2023 · 1 comment · Fixed by #4493
Assignees
@tustvold
Labels
arrow Changes to the arrow crate bug

Comments

@tustvold
Copy link
Contributor

tustvold commented Jul 8, 2023

Describe the bug

There are a couple of bugs in the interval subtraction logic:

  • It assumes negating the value negates its components, see Interval Negation Incorrect #4488 for why this is incorrect
  • It assumes negation cannot overflow
  • TimestampSecondType::subtract_day_time uses microseconds instead of milliseconds

To Reproduce

Expected behavior

Additional context
@tustvold tustvold added the bug label Jul 8, 2023
@tustvold tustvold self-assigned this Jul 8, 2023
@tustvold tustvold mentioned this issue Jul 8, 2023
Merged
@tustvold
Copy link
Contributor Author

label_issue.py automatically added labels {'arrow'} from #4493

@tustvold tustvold added the arrow Changes to the arrow crate label Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tustvold tustvold

Labels
arrow Changes to the arrow crate bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Datum Arithmetic tests, Fix Interval Substraction (#4480) tustvold/arrow-rs
1 participant
@tustvold