Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ObjectStore::append #3790

Closed
tustvold opened this issue Mar 2, 2023 · 4 comments
Closed

Add ObjectStore::append #3790

tustvold opened this issue Mar 2, 2023 · 4 comments
Labels
enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface

Comments

@tustvold
Copy link
Contributor

tustvold commented Mar 2, 2023

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Some use-cases, such as apache/datafusion#5130, would like to re-open a file and append rows to it.

Describe the solution you'd like

I would like an ObjectStore::append method that can be implemented for stores that support it. This would need a disclaimer that not all stores can support it, and that the atomicity guarantees are significantly weaker than for the other APIs.

Describe alternatives you've considered

Additional context
@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Mar 2, 2023
@tustvold tustvold mentioned this issue Mar 2, 2023
Merged
@alamb
Copy link
Contributor

alamb commented Mar 7, 2023

What else is left for this ticket, I wonder?

@tustvold
Copy link
Contributor Author

tustvold commented Mar 7, 2023

It needs to be actually implemented 😅 #3791 just added the API

@tustvold
Copy link
Contributor Author

Closed by #3824

@tustvold
Copy link
Contributor Author

label_issue.py automatically added labels {'object-store'} from #3791

@tustvold tustvold added the object-store Object Store Interface label Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alamb @tustvold