Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip null buffer when importing FFI ArrowArray struct if no null buffer in the spec #3290

Closed
viirya opened this issue Dec 7, 2022 · 1 comment · Fixed by #3293
Closed
Labels
arrow Changes to the arrow crate bug

Comments

@viirya
Copy link
Member

viirya commented Dec 7, 2022

Describe the bug

See #3276 (comment).

Currently we load the buffer at index 0 of buffers fields from FFI ArrowArray struct. However, it could load wrong buffer as null buffer for the types where is no null buffer, e.g., UnionArray.

To Reproduce

Expected behavior

Additional context

C++ Arrow exporter: https://github.com/apache/arrow/blob/26a426f325256e260a15521d5097efffd2f1ceb1/cpp/src/arrow/c/bridge.cc#L556C14-L566

@viirya
Copy link
Member Author

viirya commented Dec 7, 2022

Actually we may need to exclude null buffer exporting for such types too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants