Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check overflow when casting floating point value to decimal128 #3020

Closed
viirya opened this issue Nov 5, 2022 · 1 comment · Fixed by #3021
Closed

Check overflow when casting floating point value to decimal128 #3020

viirya opened this issue Nov 5, 2022 · 1 comment · Fixed by #3021
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@viirya
Copy link
Member

viirya commented Nov 5, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Part of #2986.

This deals with the case of casting floating point value to decimal128.

Describe the solution you'd like

Describe alternatives you've considered

Additional context
@viirya viirya added the enhancement Any new improvement worthy of a entry in the changelog label Nov 5, 2022
@viirya viirya mentioned this issue Nov 5, 2022
Merged
@alamb
Copy link
Contributor

alamb commented Nov 11, 2022

label_issue.py automatically added labels {'arrow'} from #3021

@alamb alamb added the arrow Changes to the arrow crate label Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check overflow while casting floating point value to decimal128 viirya/arrow-rs
2 participants
@viirya @alamb