Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the output of read_buffer Arrow IPC API to return Result<_> #2342

Closed
liukun4515 opened this issue Aug 6, 2022 · 0 comments · Fixed by #2369
Closed

Change the output of read_buffer Arrow IPC API to return Result<_> #2342

liukun4515 opened this issue Aug 6, 2022 · 0 comments · Fixed by #2369
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@liukun4515
Copy link
Contributor

do you still intend to make this change? Or is it planned for a subsequent PR?

Originally posted by @alamb in #1855 (comment)

There is maybe some error when read the ipc buffer, we should change the output of result to
@liukun4515 liukun4515 mentioned this issue Aug 6, 2022
Closed
@alamb alamb changed the title change the output of read_buffer API change the output of read_buffer API to return a Result<_> Aug 6, 2022
@alamb alamb added enhancement Any new improvement worthy of a entry in the changelog arrow Changes to the arrow crate labels Aug 6, 2022
@liukun4515 liukun4515 mentioned this issue Aug 11, 2022
Merged
@alamb alamb changed the title change the output of read_buffer API to return a Result<_> Change the output of read_buffer Arrow IPC API to return Result<_> Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support compression for IPC with revamped feature flags alamb/arrow-rs
2 participants
@alamb @liukun4515