Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix maximum and minimum for decimal values for precision greater than 38 #2246

Closed
viirya opened this issue Jul 30, 2022 · 1 comment · Fixed by #2245
Closed

Fix maximum and minimum for decimal values for precision greater than 38 #2246

viirya opened this issue Jul 30, 2022 · 1 comment · Fixed by #2245
Labels
arrow Changes to the arrow crate bug

Comments

@viirya
Copy link
Member

viirya commented Jul 30, 2022

Describe the bug

I made a mistake when filling out MAX_DECIMAL_FOR_LARGER_PRECISION and MIN_DECIMAL_FOR_EACH_PRECISION. It is less one digit for each value.

To Reproduce

Expected behavior

Additional context
@viirya viirya added the bug label Jul 30, 2022
@viirya viirya mentioned this issue Jul 30, 2022
Merged
@viirya viirya changed the title Fix maximum and minimum for decimal values for precision > 38 Fix maximum and minimum for decimal values for precision greater than 38 Jul 30, 2022
@alamb
Copy link
Contributor

alamb commented Aug 1, 2022 •
edited
Loading

FWIW this was found by the arrow integration test apache/arrow#13685 🎉

@alamb alamb added the arrow Changes to the arrow crate label Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix max and min value for decimal precision greater than 38 viirya/arrow-rs
2 participants
@viirya @alamb