Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Sliced Complex Types In IPC Writer #2080

Closed
tustvold opened this issue Jul 15, 2022 · 1 comment
Closed

Support Sliced Complex Types In IPC Writer #2080

tustvold opened this issue Jul 15, 2022 · 1 comment
Assignees
Labels

Comments

@tustvold
Copy link
Contributor

Describe the bug

#2040 fixed handling of sliced primitive, dictionary and byte arrays. However, the logic will still currently misbehave for complex types such as

  • ListArray
  • UnionArray
  • StructArray

This is because it will fail to push down the offset in the "parent" into the leaf arrays.

To Reproduce

Attempt to roundtrip a sliced one of these arrays, and it will fail

Expected behavior

Writing a sliced array of any type should work

Additional context

#1799 might simplify the implementation of this, as it would allow removing offset from ArrayData

@tustvold
Copy link
Contributor Author

tustvold commented May 9, 2023

Closed by #4061

@tustvold tustvold closed this as completed May 9, 2023
@tustvold tustvold self-assigned this May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant