Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't double-count nulls in write_batch_with_statistics #2046

Closed
tustvold opened this issue Jul 11, 2022 · 0 comments · Fixed by #2047
Closed

Don't double-count nulls in write_batch_with_statistics #2046

tustvold opened this issue Jul 11, 2022 · 0 comments · Fixed by #2047
Labels
bug parquet Changes to the parquet crate

Comments

@tustvold
Copy link
Contributor

Describe the bug

Currently if you pass a non-zero null count to write_batch_with_statistics, it will add this to the metrics deduced from the pages.

To Reproduce

Use write_batch_with_statistics with a non-zero null counts

Expected behavior

Passing a null count shouldn't result in incorrect statistics
@tustvold tustvold added the bug label Jul 11, 2022
@tustvold tustvold mentioned this issue Jul 11, 2022
Merged
@alamb alamb changed the title Don't double-count nulls in write_batch_with_statistics Don't double-count nulls in write_batch_with_statistics Jul 21, 2022
@alamb alamb added the parquet Changes to the parquet crate label Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove null_count from write_batch_with_statistics tustvold/arrow-rs
2 participants
@alamb @tustvold