Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add from(v: Vec<Option<&[u8]>>) and from(v: Vec<&[u8]>) for FixedSizedBInaryArray #1852

Closed
HaoYang670 opened this issue Jun 13, 2022 · 0 comments · Fixed by #1854
Closed

Add from(v: Vec<Option<&[u8]>>) and from(v: Vec<&[u8]>) for FixedSizedBInaryArray #1852

HaoYang670 opened this issue Jun 13, 2022 · 0 comments · Fixed by #1854
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@HaoYang670
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Found when working on #1801.
We already have try_from_sparse_iter and try_from_iter for FixedSizedBInaryArray. It is easily to add from(v: Vec<Option<&[u8]>>) and from(v: Vec<&[u8]>) based on the two.
@HaoYang670 HaoYang670 added the enhancement Any new improvement worthy of a entry in the changelog label Jun 13, 2022
This was referenced Jun 13, 2022
Merged
Merged
@alamb alamb added the arrow Changes to the arrow crate label Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add two from methods for FixedSizeBinaryArray HaoYang670/arrow-rs
2 participants
@alamb @HaoYang670