Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve substring kernel performance #1422

Closed
viirya opened this issue Mar 10, 2022 · 0 comments · Fixed by #1423
Closed

Improve substring kernel performance #1422

viirya opened this issue Mar 10, 2022 · 0 comments · Fixed by #1423
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog performance

Comments

@viirya
Copy link
Member

viirya commented Mar 10, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Currently in substring kernel, we use a Vec to put substrings and then copy strings from it to make a buffer. We can directly write into a buffer using MutableBuffer to avoid memory copying.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@viirya viirya added the enhancement Any new improvement worthy of a entry in the changelog label Mar 10, 2022
@alamb alamb added performance arrow Changes to the arrow crate labels Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants