Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support MapArray in filter kernel #1378

Closed
helgikrs opened this issue Mar 2, 2022 · 0 comments · Fixed by #1379
Closed

Support MapArray in filter kernel #1378

helgikrs opened this issue Mar 2, 2022 · 0 comments · Fixed by #1379
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@helgikrs
Copy link
Contributor

helgikrs commented Mar 2, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Using arrow::compute::kernels::filter::filter and arrow::compute::kernels::filter::filter_record_batch on arrays (or record batches respectively) containing MapArrays produces a panic such as

panicked at 'not yet implemented: Take and filter operations still not supported for this datatype', arrow/src/array/transform/mod.rs:520:17

Describe the solution you'd like
It should just like it does for lists.
@helgikrs helgikrs added the enhancement Any new improvement worthy of a entry in the changelog label Mar 2, 2022
@helgikrs helgikrs mentioned this issue Mar 2, 2022
Merged
@alamb alamb changed the title filter kernel should work with MapArrays Support MapArray in filter kernel Mar 3, 2022
@alamb alamb added the arrow Changes to the arrow crate label Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support maps in MutableArrayData helgikrs/arrow-rs
2 participants
@helgikrs @alamb