Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the integration-testing/unskip.patch file #1067

Closed
alamb opened this issue Dec 20, 2021 · 1 comment
Closed

Remove the integration-testing/unskip.patch file #1067

alamb opened this issue Dec 20, 2021 · 1 comment
Labels
arrow Changes to the arrow crate development-process Related to development process of arrow-rs enhancement Any new improvement worthy of a entry in the changelog

Comments

@alamb
Copy link
Contributor

alamb commented Dec 20, 2021

Context from @b41sh -- #779 (comment)

This file is a local change that is applied to the overall arrow integration tests. Once the upstream arrow pr apache/arrow#11238 has been merged, we will not have to apply this patch anymore in arrow.

This ticket tracks removing it
@alamb alamb added arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog development-process Related to development process of arrow-rs labels Dec 20, 2021
@alamb alamb mentioned this issue Dec 20, 2021
Merged
@b41sh
Copy link
Contributor

b41sh commented Dec 21, 2021

sorry, I have removed this file before the PR merge, we can close this issue.

@alamb alamb closed this as completed Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate development-process Related to development process of arrow-rs enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alamb @b41sh