Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Improve testing of Dataset bindings #304

Open
asfimport opened this issue Aug 8, 2022 · 1 comment
Open

[Java] Improve testing of Dataset bindings #304

asfimport opened this issue Aug 8, 2022 · 1 comment
Labels
Type: enhancement New feature or request

Comments

@asfimport
Copy link

From apache/arrow#13811

  • We should ensure all types are tested

  • We should organize tests in a way that Parquet, IPC, and eventually CSV/ORC can mostly share test code (save for perhaps skipping/overriding specific format-type pairs)

    Incidentally: it may be good to incrementally port this module to JUnit5 and drop JUnit4

Reporter: David Li / @lidavidm

Note: This issue was originally created as ARROW-17342. Please see the migration documentation for further details.

@asfimport
Copy link
Author

David Li / @lidavidm:
We also shouldn't round-trip through JSON to test for equality; we should just use VectorSchemaRoot#equals or something equivalent (if we wanted to be very nice, we should provide something that'll also print a diff)

@assignUser assignUser transferred this issue from apache/arrow Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant