Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(csharp/src/Drivers/BigQuery): remove details to have type names match ODBC #2431

Merged
merged 3 commits into from
Jan 12, 2025
Merged

fix(csharp/src/Drivers/BigQuery): remove details to have type names match ODBC #2431

merged 3 commits into from
Jan 12, 2025
+110 −14

Conversation

davidhcoe
Copy link
Contributor

@davidhcoe davidhcoe commented Jan 10, 2025 •
edited
Loading

  • removes additional suffix details from data type names. For example, STRUCT<...> is just a STRUCT type, and NUMERIC(n,y) is just NUMERIC to match the ODBC type names.
  • adds support for querying additional table types

@github-actions github-actions bot added this to the ADBC Libraries 17 milestone Jan 10, 2025
CurtHagenlocher
CurtHagenlocher requested changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@CurtHagenlocher CurtHagenlocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good overall. Although it's a preexisting condition, I think we should fix the consistency around the parsing of decimal types. The other suggestions are optional.

csharp/src/Drivers/BigQuery/BigQueryConnection.cs Outdated Show resolved Hide resolved
csharp/src/Drivers/BigQuery/BigQueryConnection.cs Show resolved Hide resolved
csharp/src/Drivers/BigQuery/BigQueryTableTypes.cs Outdated Show resolved Hide resolved
csharp/test/Apache.Arrow.Adbc.Tests/Metadata/GetObjectsParser.cs Outdated Show resolved Hide resolved
@davidhcoe
Copy link
Contributor Author

Thanks! Looks good overall. Although it's a preexisting condition, I think we should fix the consistency around the parsing of decimal types. The other suggestions are optional.

Is this referring to the < vs ( parsing? Or something else?

CurtHagenlocher
CurtHagenlocher reviewed Jan 11, 2025
View reviewed changes
csharp/src/Drivers/BigQuery/BigQueryConnection.cs Outdated
@@ -738,7 +743,7 @@ private StructArray GetConstraintsUsage(
dataArrays,
nullBitmapBuffer.Build());
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the trailing whitespace that the tooling is complaining about.

@CurtHagenlocher
Copy link
Contributor

CurtHagenlocher commented Jan 11, 2025 •
edited
Loading

Is this referring to the < vs ( parsing? Or something else?

Yes. I see; I had the mistaken impression that this was being called from inside the if (dataType.StartsWith("NUMERIC" ... block.

CurtHagenlocher
CurtHagenlocher approved these changes Jan 11, 2025
View reviewed changes
Copy link
Contributor

@CurtHagenlocher CurtHagenlocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trailing whitespace at line 746 of BigQueryConnection.cs will need to be removed to pass the checkin tests.

@CurtHagenlocher CurtHagenlocher merged commit c3149c0 into apache:main Jan 12, 2025
6 checks passed
@davidhcoe davidhcoe deleted the dev/bq-datatypes branch January 12, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CurtHagenlocher CurtHagenlocher CurtHagenlocher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 17
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhcoe @CurtHagenlocher