Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discuss: apisix-ingress-controller version update in Makefile #553

Closed
fhuzero opened this issue Jun 21, 2021 · 3 comments
Closed

discuss: apisix-ingress-controller version update in Makefile #553

fhuzero opened this issue Jun 21, 2021 · 3 comments

Comments

@fhuzero
Copy link
Contributor

fhuzero commented Jun 21, 2021

Now apisix-ingress-controller has released its first GA version 1.0.x, but the default version in Makefile is still 0.6.0 (here). Should we update it to 1.0.x? If so, I can open a PR to keep it up-to-date.
@tao12345666333
Copy link
Member

yes, please!

@fhuzero fhuzero mentioned this issue Jun 21, 2021
Closed
@fhuzero
Copy link
Contributor Author

fhuzero commented Jun 21, 2021

yes, please!

Thanks! I have created a PR.

@fhuzero fhuzero mentioned this issue Jun 21, 2021
Merged
@fhuzero
Copy link
Contributor Author

fhuzero commented Jun 23, 2021

The related PR #556 has been merged so I'll close this issue.

@fhuzero fhuzero closed this as completed Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tao12345666333 @fhuzero