Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: active check & plugin form #1793

Merged
merged 2 commits into from
Apr 19, 2021
Merged

fix: active check & plugin form #1793

merged 2 commits into from
Apr 19, 2021

Conversation

LiteSun
Copy link
Member

@LiteSun LiteSun commented Apr 19, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

Changes

  • fix active check
  • fix plugin form

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases (TODO)?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented Apr 19, 2021

Deploy preview for apisix-dashboard ready!

Built with commit 89a23a5

https://deploy-preview-1793--apisix-dashboard.netlify.app

@LiteSun LiteSun requested a review from juzhiyuan April 19, 2021 09:26
@juzhiyuan
Copy link
Member

realted PR: #1792

@codecov-commenter
Copy link

Codecov Report

Merging #1793 (89a23a5) into master (5406ba3) will increase coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1793      +/-   ##
==========================================
+ Coverage   71.76%   71.99%   +0.22%     
==========================================
  Files         172      125      -47     
  Lines        6064     2921    -3143     
  Branches      703      703              
==========================================
- Hits         4352     2103    -2249     
+ Misses       1467      818     -649     
+ Partials      245        0     -245     
Flag Coverage Δ
backend-e2e-test ?
backend-e2e-test-ginkgo ?
backend-unit-test ?
frontend-e2e-test 71.99% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...components/active-check/HttpsVerifyCertificate.tsx 33.33% <ø> (ø)
web/src/components/Plugin/PluginDetail.tsx 62.93% <100.00%> (+0.69%) ⬆️
web/src/components/Plugin/UI/basic-auth.tsx 66.66% <0.00%> (-33.34%) ⬇️
web/src/components/Plugin/UI/plugin.tsx 82.60% <0.00%> (-8.70%) ⬇️
api/internal/handler/label/label.go
api/cmd/managerapi.go
api/internal/handler/data_loader/route_export.go
api/internal/core/store/store.go
api/internal/core/store/store_mock.go
api/internal/utils/pid.go
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5406ba3...89a23a5. Read the comment docs.

@LiteSun LiteSun requested a review from Yiyiyimu April 19, 2021 11:28
@LiteSun LiteSun merged commit e19c960 into apache:master Apr 19, 2021
nic-chen pushed a commit that referenced this pull request Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants