Add missing priorityClassName to K8S worker pod template #31328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test here? |
hussein-awala
force-pushed
the
fix/priorityClassName
branch
from
484d9ed to
4ec5a50
Compare
|
@jedcunningham can you check it now? |
amoghrajesh
reviewed
May 22, 2023
amoghrajesh
reviewed
May 30, 2023
There was a problem hiding this comment.
@hussein-awala why dont we also add these changes in chart/templates/workers/worker-deployment.yaml?
Nevermind. I see that is already exists |
jedcunningham
approved these changes
Jun 1, 2023
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #31311
This PR adds
priorityClassNameto the pod template of the KubernetesExecutor workers when it is provided toValues.workers.priorityClassName^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.